Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Include the region query param on the View Raw File link in the task fs explorer #8509

Merged
merged 2 commits into from
Jul 22, 2020
Merged

UI: Include the region query param on the View Raw File link in the task fs explorer #8509

merged 2 commits into from
Jul 22, 2020

Conversation

DingoEatingFuzz
Copy link
Contributor

Fixes #8166

I think this is the last region related UI bug that has been reported???

Pretty straightforward fix for an oversight.

@DingoEatingFuzz DingoEatingFuzz added this to the 0.12.1 milestone Jul 22, 2020
@github-actions
Copy link

github-actions bot commented Jul 22, 2020 •
edited
Loading

Ember Asset Size action

As of 357564e

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +229 B +61 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

backspace
backspace approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@backspace backspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! I long for some magical lint-esque facility that would let us know when something should be region-aware but that seems infeasible 😞

@DingoEatingFuzz
Copy link
Contributor Author

That sounds like the dream though!

@github-actions
Copy link

github-actions bot commented Jul 22, 2020 •
edited
Loading

Ember Test Audit comparison

master 357564e change
passes 1315 1316 +1
failures 0 0 0
flaky 0 0 0
duration 5m 55s 319ms 6m 09s 149ms +13s 830ms

@DingoEatingFuzz DingoEatingFuzz merged commit 3593f57 into master Jul 22, 2020
@DingoEatingFuzz DingoEatingFuzz deleted the b-ui/view-raw-include-region branch July 22, 2020 21:21
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@backspace backspace backspace approved these changes

Assignees
No one assigned
Labels
theme/ui
Projects
None yet
Milestone
0.12.1
Development

Successfully merging this pull request may close these issues.

Nomad UI 'View Raw File' does not pass region parameter
2 participants
@DingoEatingFuzz @backspace