Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove possibility of nil allocs from CSI volume/plugin #8734

Closed
tgross opened this issue Aug 25, 2020 · 2 comments
Closed

remove possibility of nil allocs from CSI volume/plugin #8734

tgross opened this issue Aug 25, 2020 · 2 comments

Comments

@tgross
Copy link
Member

tgross commented Aug 25, 2020

CSI volumes have references to allocations that get "denormalized" when we read them out of the state store. This has been a bug farm for us whenever we run into allocations that have been GC'd, and we've had to play wack-a-mole to fix this category of bug. The best way to do this is probably to avoid reading WriteAllocs and ReadAllocs at all at the server and treat it only as a value to send back to the CLI/UI, keeping the values of interest in WriteClaims and ReadClaims.

cc @langmartin for your thoughts

@tgross
Copy link
Member Author

tgross commented Jan 28, 2022

This issue has been worked over in #10927 and patched with #11890 #11932 #11931 #11892. We'll be issuing a patch release shortly for that fix. I'm going to close this issue.

Follow from #10927 (comment) for more information.

@tgross tgross closed this as completed Jan 28, 2022
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant