Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escapingio reader test failure #8736

Closed
tgross opened this issue Aug 25, 2020 · 1 comment · Fixed by #8798
Closed

escapingio reader test failure #8736

tgross opened this issue Aug 25, 2020 · 1 comment · Fixed by #8798

Comments

@tgross
Copy link
Member

tgross commented Aug 25, 2020

We have a test that for helper/escapingio/reader (used to support nomad alloc exec) that generates random data for every unit test. The thinking here probably being that if we capture every unit test run we'll get the equivalent of a fuzz test over time. In CircleCI job 94353 this encountered a test failure:

Failed
=== RUN   TestEscapingReader_Generated_EquivalentToReadOnce
    reader_test.go:311: escaped differed=true expected=..q found=.q
    reader_test.go:312: read  differed=true expected=񘦞􈕗
        󑟱򓖐򕮇񔡖𲷒򱞧򃌖񺪔򬶄
        ~
        ƕ𿰾󌖴񗒠
        ~q𗚇~~򔍚򕯫򻐦
        򾈦𭕎 found=񘦞􈕗
        󑟱򓖐򕮇񔡖𲷒򱞧򃌖񺪔򬶄
        ~
        ~.ƕ𿰾󌖴񗒠
        ~q𗚇~~򔍚򕯫򻐦
        򾈦𭕎
    reader_test.go:322: 
        	Error Trace:	reader_test.go:322
        	Error:      	Received unexpected error:
        	            	#2878: failed on input "\U0005899e\U00108557\n~.\U000d17f1\U00093590\U00095b87\U00054856\U00032dd2\U000b17a7\U00083316\U0007aa94\U000acd84\n~\n~.ƕ\U0003fc3e\U000cc5b4\U000574a0\n~q𗚇~~\U0009435a\U00095beb\U000bb426\n\U000be226𭕎"
        	Test:       	TestEscapingReader_Generated_EquivalentToReadOnce
--- FAIL: TestEscapingReader_Generated_EquivalentToReadOnce (0.19s)

(Going to cc @notnoop on this one as I'm unfamiliar with this area of the code and he's the original author... doesn't seem critical though)

@github-actions
Copy link

github-actions bot commented Nov 2, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants