Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

job ID allows null character #8796

Closed
cgbaker opened this issue Aug 31, 2020 · 1 comment · Fixed by #9020
Closed

job ID allows null character #8796

cgbaker opened this issue Aug 31, 2020 · 1 comment · Fixed by #9020
Assignees
Labels
Milestone

Comments

@cgbaker
Copy link
Contributor

cgbaker commented Aug 31, 2020

Nomad version

nomad 0.12.3

Issue

validation for nomad job name and ID does not prohibit the null character. the job can be registered, but it causes unexpected problems downstream with multiple task drivers, and potentially causes problems because of indexing in memdb.

job validation should prohibit null character from name/ID of job, task group, task, etc..

this is a breaking change and should be added to the upgrade guide for the release which include it.

Update

The following environment variables are set in each task:

  • NOMAD_REGION=global
  • NOMAD_DC=dc1
  • NOMAD_NAMESPACE=default
  • NOMAD_JOB_NAME=example
  • NOMAD_GROUP_NAME=cache
  • NOMAD_TASK_NAME=redis
  • NOMAD_PORT_db=6379
  • NOMAD_ALLOC_NAME=example.cache[0]

If any of region, dc, namespace, job id/name, group name, task name, or port name include null characters, this will fail for most task drivers.

Namespace and port are currently restricted. Region, DC and the job identifiers are not.

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant