UI: Add handling for allocation-less exec URL #8856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This closes #8769. This new-window-opening code is not possible to properly exercise within Ember’s testing facilities 😞
Ember Asset Size actionAs of 1f593bc Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
DingoEatingFuzz
approved these changes
Sep 15, 2020
notnoop
pushed a commit
that referenced
this pull request
Sep 16, 2020
This closes #8769. This new-window-opening code is not possible to properly exercise within Ember’s testing facilities 😞
fredrikhgrelland
pushed a commit
to fredrikhgrelland/nomad
that referenced
this pull request
Sep 28, 2020
This closes hashicorp#8769. This new-window-opening code is not possible to properly exercise within Ember’s testing facilities 😞
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #8769. This new-window-opening code is not possible
to properly exercise within Ember’s testing facilities 😞