Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qemu driver config documentation incorrect #8960

Closed
colindunn opened this issue Sep 23, 2020 · 3 comments
Closed

qemu driver config documentation incorrect #8960

colindunn opened this issue Sep 23, 2020 · 3 comments

Comments

@colindunn
Copy link

Nomad version

# nomad version
Nomad v0.11.3 (8918fc804a0c6758b6e3e9960e4eb2e605e38552)

Operating system and Environment details

Ubuntu 20.04

Issue

According to https://www.nomadproject.io/docs/drivers/qemu#image_paths the config for the qemu driver should be in the form of the following:

plugin "qemu" {
  config {
    image_paths = ["/data/images"]
  }
}

But if I set that value in the config, nomad fails to load with the following error:

Sep 24 09:28:27 node12 nomad[1099]: #011* plugin "qemu" (driver): failed to parse config:  Invalid label: No argument or block type is named "image_paths".

If I set the config to the following, nomad is able to start:

plugin "qemu" {
  image_paths = ["/data/images"]
}

Reproduction steps

As noted above in the issue description

Job file (if appropriate)

N/A

Nomad Client logs (if appropriate)

N/A

Nomad Server logs (if appropriate)

Sep 24 09:28:27 node12 nomad[1099]: #011* plugin "qemu" (driver): failed to parse config:  Invalid label: No argument or block type is named "image_paths".
@tgross
Copy link
Member

tgross commented Sep 24, 2020

Hi @colindunn!

I just checked the code history and I don't think the image_paths configuration is valid at all in Nomad 0.11.3. That was introduced in 0.12.0 by #8261. I suspect that in the case you have where it's "working" it's slipping by the configuration parser but the value isn't being handled at all. If you were to try to run a QEMU task with an image outside the image_paths list it will probably work, showing that the field isn't being used.

(That also means we have a bug in our configuration parsing that image_paths is allowed in a place it shouldn't be, but it's not one we're likely to fix in a backported version of Nomad.)

@tgross
Copy link
Member

tgross commented Oct 1, 2020

I've opened #9001 about the overly-generous config parser.

@tgross tgross closed this as completed Oct 1, 2020
@github-actions
Copy link

github-actions bot commented Nov 1, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants