removed backwards-compatible/untagged metrics deprecated in 0.7 #9080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgbaker
force-pushed
the
f-remove-deprecated-metrics
branch
from
6a0f5aa
to
06a41f0
Compare
cgbaker
force-pushed
the
f-remove-deprecated-metrics
branch
from
06a41f0
to
40c119c
Compare
cgbaker
added
theme/config
theme/docs
schmichael
approved these changes
Oct 13, 2020
nickethier
reviewed
Oct 13, 2020
in the telemetry section? I added them to the upgrade guide. |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nomad v0.7.0 introduced tagged metrics that were incompatible with previous emitted metrics. Two new configurations were added to gate this new behavior: one to enable/disabled the tagged metrics, one to enable/disable the backwards compatible metrics. At that point in time, the untagged metrics were marked as deprecated.
That was a long time ago. This PR fulfills the prophecy of that deprecation and removes the BC metrics, as well as removes the fields for the deprecated configuration.