Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI volume shows controller health as unhealthy even when no controller is needed #9252

Closed
apollo13 opened this issue Nov 2, 2020 · 3 comments · Fixed by #9416
Closed

CSI volume shows controller health as unhealthy even when no controller is needed #9252

apollo13 opened this issue Nov 2, 2020 · 3 comments · Fixed by #9416
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/bad-ux theme/storage
Milestone

Comments

@apollo13
Copy link
Contributor

apollo13 commented Nov 2, 2020

Nomad version

0.12.5

Issue

The Storage -> Volume tab says unhealthy for controller health for my CSI plugin:
image

Since my plugin does not require a controller, it would be great if the UI could give one the benefit of the doubt if no controller is running. After all it lists it as Schedulable which probably wouldn't work either if a healthy controller were a requirement :)

Reproduction steps

Use any CSI plugin that does not need a controller.

@tgross tgross added theme/storage theme/bad-ux stage/accepted Confirmed, and intend to work on. No timeline committment though. labels Nov 2, 2020
@tgross
Copy link
Member

tgross commented Nov 2, 2020

Thanks for noticing this @apollo13. Definitely something that'd be nice to polish up.

@tgross
Copy link
Member

tgross commented Nov 20, 2020

@apollo13 I was able to reproduce this with a node-only plugin. The screenshot below is the AWS EFS plugin on Nomad 0.12.7:

Screen Shot 2020-11-20 at 2 29 42 PM

Whereas the plugin tab shows it correctly:

Screen Shot 2020-11-20 at 2 18 34 PM

The API includes a field ControllerRequired which the web UI uses to gray-out that field if one isn't required. So that's not getting referenced in that volume tab for some reason. Should be a small fix.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/bad-ux theme/storage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants