recommendations CLI: autocomplete support #9317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndations prefix search
cgbaker
force-pushed
the
f-recommendations-cli-autocomplete
branch
from
e77fbe9
to
316ca44
Compare
…f autocompletion code
krishicks
approved these changes
Nov 11, 2020
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relies on and provides structure for
/v1/searchsupport in Enterprise, which will be merged nextthe autocomplete support is redundant across all of the supported commands:
apply,dismiss, andinfo, and I just copied it between them. this seems a little gross, but it's the same pattern used in thenomad jobcommands andnomad deploymentcommands (where it is repeated 6 times)update: refactored to reduce redundancy in autocomplete code. 🤷