raw_exec: don't use cgroups when no_cgroup is set #9328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 11, 2020 15:17
Test that the universal executor (used for raw_exec) avoids using cgroup when `no_cgroup` is a cgroup
[ci skip]
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When raw_exec is configured with
no_cgroups, raw_exec shouldn't attempt to create a cgroup.Prior to this change, we accidentially always required freezer cgroup to do stats PID tracking. We already have the proper fallback in place for metrics, so only need to ensure that we don't create a cgroup for the task.
I've added the tests in a commit first. You can see the failure in https://app.circleci.com/pipelines/github/hashicorp/nomad/13091/workflows/b2d02203-1a9b-4c46-92b1-7b35e58ed63a/jobs/117359 where
freezercgroup differed from expected.Fixes #8565