fix duplication of ports in AllocatedResources
#9368
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9367 suggests that the canonicalization of
structs.Allocation.AllocatedResources
is mutating the memdb object, causing the number of ports to grow on every callthere are a few solutions here:
documenting test in the first commit:
https://app.circleci.com/pipelines/github/hashicorp/nomad/13195/workflows/63c91dd0-ea6e-440e-b080-50b68b680dbc/jobs/118749
copy-based fix in the second commit:
https://app.circleci.com/pipelines/github/hashicorp/nomad/13196/workflows/c857a136-5584-4d3f-ad10-6684bc7f9c68/jobs/118744