Download artifacts to relative locations inside the task directory #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadgar
force-pushed
the
f-artifact-location
branch
from
bd6dcb5
to
a55b4fc
Compare
| if err != nil { | ||
| return nil, err | ||
| } | ||
| path = rel |
There was a problem hiding this comment.
Defense in depth, I would re-verify that taskDir is a parent of absPath
There was a problem hiding this comment.
Doing the check here is unnecessary as if the path has escaped, it will be invalid inside the chroot.
|
Minor comments, LGTM |
dadgar
added a commit
that referenced
this pull request
Mar 19, 2016
Download artifacts to relative locations inside the task directory
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: