-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
review adding timeouts to Docker API calls #9503
Comments
Hi to anybody reading this - We think this is a good first issue and good candidate for a community PR. Probably not something the HashiCorp team will get to right away though. This would involve finding all the places where we call the docker API and adding a timeout there. For example, for a call like this one could add a go context with a timeout. |
@tgross sorry for spamming a bunch of issues around here but I think I'll take a shot at this one based on @mikenomitch's comment. Hope that's okay. |
Go for it! |
Hey, I had a question about this. So, we're exclusively talking about attaching context as part of calls to the docker engine made from the docker client, is that correct? Also, this could change if we're exporting a specific call e.g. I made a small draft change for the |
Hi @danishprakash!
Yes! We don't want to bubble that all the way up to the callers in
The |
From #9502:
The text was updated successfully, but these errors were encountered: