Allow client.cpu_total_compute to override attr.cpu.totalcompute #9532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). nomad-storybook-and-ui – ./ui🔍 Inspect: https://vercel.com/hashicorp/nomad-storybook-and-ui/h49osv8hb |
joel0
force-pushed
the
totalcompute-override
branch
from
726c08b
to
360f588
Compare
|
@joel0 is attempting to deploy a commit to the HashiCorp Team on Vercel. A member of the Team first needs to authorize it. |
tgross
added a commit
that referenced
this pull request
Jan 7, 2021
tgross
added a commit
that referenced
this pull request
Jan 7, 2021
backspace
pushed a commit
that referenced
this pull request
Jan 22, 2021
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation states that
${attr.cpu.totalcompute}may be overridden byclient.cpu_total_compute. The actual behaviour was thatattr.cpu.totalcomputewas unset whencpu_total_computewas used.I think either the feature should operate how the documentation says, or the documentation should be updated. I opted for changing the feature, as I think it would be useful.