Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt raft-autopilot library #9570

Closed
notnoop opened this issue Dec 8, 2020 · 3 comments · Fixed by #14441
Closed

Adopt raft-autopilot library #9570

notnoop opened this issue Dec 8, 2020 · 3 comments · Fixed by #14441
Assignees
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/autopilot type/tech-debt
Milestone

Comments

@notnoop
Copy link
Contributor

notnoop commented Dec 8, 2020

Nomad currently directly imports Consul's private autopilot package (github.com/hashicorp/consul/agent/consul/autopilot). Last month, Consul extracted autopilot to be its own module to ease adoption in other products: https://github.com/hashicorp/raft-autopilot

Let's move off our direct dependency on the internal repo in preference to the new module.

@notnoop notnoop added theme/autopilot stage/accepted Confirmed, and intend to work on. No timeline committment though. type/tech-debt labels Dec 8, 2020
@tgross tgross added this to Needs Roadmapping in Nomad - Community Issues Triage Feb 12, 2021
@tgross tgross removed this from Needs Roadmapping in Nomad - Community Issues Triage Mar 4, 2021
@lgfa29 lgfa29 added this to the 1.4.0 milestone Mar 24, 2022
@tgross
Copy link
Member

tgross commented Jun 6, 2022

Note to implementor: probably worth doing #13219 at the same time.

@shoenig
Copy link
Member

shoenig commented Jun 27, 2022

Took a brief look into making the switch; looks like it's going to be a bit more complicated than just renaming imports. In addition to raft-autopilot there is also raft-autopilot-enterprise, and the features referenced by Nomad OSS in the old Consul autopilot library have been split up between the two.

Still very much want to make this happen - without it Nomad is forced to import consul v1.7 😞

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/autopilot type/tech-debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@notnoop @shoenig @lgfa29 @tgross and others