Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Guard against nodes running an old version of the Nomad agent #9733

Merged
merged 2 commits into from
Jan 7, 2021

Conversation

DingoEatingFuzz
Copy link
Contributor

Fixes #9702

If a cluster has nodes running a version of Nomad <0.9.0, they won't have the requisite NodeResources property. Instead of blowing up, now the UI will filter those nodes out of the viz and report the situation to the user.

Screen Shot 2021-01-05 at 4 17 05 PM

@github-actions
Copy link

github-actions bot commented Jan 6, 2021

Ember Asset Size action

As of 37e1551

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +1.83 kB +406 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Jan 6, 2021

Ember Test Audit comparison

master 37e1551 change
passes 1542 1544 +2
failures 0 0 0
flaky 0 0 0
duration 8m 18s 301ms 8m 25s 607ms +07s 306ms

Copy link
Contributor

@backspace backspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I’m guessing your screenshot is slightly stale given the absence of the count? 🤓

@DingoEatingFuzz
Copy link
Contributor Author

Ha, yes. Good eye.

@DingoEatingFuzz DingoEatingFuzz merged commit a53c8eb into master Jan 7, 2021
@DingoEatingFuzz DingoEatingFuzz deleted the b-ui/topo-viz-old-agent branch January 7, 2021 17:27
@github-actions
Copy link

github-actions bot commented Dec 4, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Topology broken in 1.0.1 with a JS error
2 participants