Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Successful allocations are marked as complete instead of dead #975

Merged
merged 1 commit into from
Mar 25, 2016

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Mar 24, 2016

No description provided.

@diptanu
Copy link
Contributor

diptanu commented Mar 25, 2016

So with the introduction of Complete, why do we even need Dead anymore since we also have failed?

Also how are you thinking to represent things like a task crashed because the kernel killed it - it's different from failed in a way that the environment killed it. Also, things like docker daemon crashing and hence the container crashing - is it failed?

Introducing states like complete, failed, etc required the need to invent more terminal states.

@dadgar
Copy link
Contributor Author

dadgar commented Mar 25, 2016

This doesn't introduce a new terminal state. It renaming Dead -> Complete. The distinction stays the same.

@dadgar dadgar merged commit 77f5c6e into master Mar 25, 2016
@dadgar dadgar deleted the f-rename-complete-alloc branch March 25, 2016 17:35
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants