safely handle existing net namespace in default network manager #9757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
force-pushed
the
b-default-network-hook-restart
branch
from
870d955
to
1897708
Compare
When a client restarts, the network_hook's prerun will call `CreateNetwork`. Drivers that don't implement their own network manager will fall back to the default network manager, which doesn't handle the case where the network namespace is being recreated safely. This results in an error and the task being restarted for `exec` tasks with `network` blocks (this also impacts the community `containerd` and probably other community task drivers). If we get an error when attempting to create the namespace and that error is because the file already exists and is locked by its process, then we'll return a `nil` error with the `created` flag set to false, just as we do with the `docker` driver.
tgross
force-pushed
the
b-default-network-hook-restart
branch
from
1897708
to
83b31ea
Compare
nickethier
approved these changes
Jan 11, 2021
This was referenced Nov 11, 2022
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9750. A similar problem was fixed for the Docker driver in 0.10.0 with #6315 but it looks like we missed the
execdriver and other non-Docker drivers that support network isolation.When a client restarts, the network_hook's prerun will call
CreateNetwork. Drivers that don't implement their own network manager willfall back to the default network manager, which doesn't handle the case where
the network namespace is being recreated safely. This results in an error and
the task being restarted for
exectasks withnetworkblocks (this alsoimpacts the community
containerdand probably other community task drivers).If we get an error when attempting to create the namespace and that error is
because the file already exists and is locked by its process, then we'll
return a
nilerror with thecreatedflag set to false, just as we do withthe
dockerdriver.