in Job.Scale, ensure that new count is within [min,max] configured in scaling policy #9761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… scaling policy resolves #9758
cgbaker
commented
Jan 8, 2021
| @@ -53,7 +53,7 @@ func testJobWithScalingPolicy() *Job { | |||
| job.TaskGroups[0].Scaling = &ScalingPolicy{ | |||
| Policy: map[string]interface{}{}, | |||
| Min: int64ToPtr(1), | |||
| Max: int64ToPtr(1), | |||
| Max: int64ToPtr(5), | |||
There was a problem hiding this comment.
fixing the bug meant that a test which had previously (incorrectly) passed started to fail. this makes room for that test to properly succeed.
lgfa29
approved these changes
Jan 8, 2021
There was a problem hiding this comment.
LGTM 👍
$ nomad job scale example 1
Error submitting scaling request: Unexpected response code: 400 (new scaling count cannot be less than the scaling policy minimum)
$ nomad job scale example 100
Error submitting scaling request: Unexpected response code: 400 (new scaling count cannot be greater than the scaling policy maximum)A small suggestion would be to have the min/max value in the error message (and maybe call it group count instead of scaling count?)
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
Job.Scaleendpoint did not enforce min/max from the group scaling policy. this PR addresses that with a simple check. unit tested the RPC; I had to make a small tweak to one of theapiscaling tests because it was previously (incorrectly) scaling outside of bounds.resolves #9758