Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI consistency issues with namespaces selector. #9814

Closed
apollo13 opened this issue Jan 14, 2021 · 3 comments · Fixed by #9876
Closed

UI consistency issues with namespaces selector. #9814

apollo13 opened this issue Jan 14, 2021 · 3 comments · Fixed by #9876

Comments

@apollo13
Copy link
Contributor

apollo13 commented Jan 14, 2021

The UI namespace switcher displays a "special" name for the default namespace:

{{#if (eq namespace.name "default")}}
Default Namespace
{{else}}
{{namespace.name}}
{{/if}}

Since the actual name is simply default I also have my namespaces created in lowercase:

nomad namespace list
Name     Description
default  Default shared namespace
infra    Infrastructure
storage  CSI storage

This makes for a kinda weird display in the UI. I'd like to ask to either show the description for all namespaces (probably not the best idea) or remove the special handling of the default namespace during display.

I realize that this all might seem stupid given the other issues that are open, but I think a consistent display is worthwhile in the long run.

@DingoEatingFuzz
Copy link
Contributor

I too appreciate consistency!

The special casing of the default namespace was actually just a clever hack to make it known that the dropdown is even for namespaces. I opened #9876 with a fix for this.

@apollo13
Copy link
Contributor Author

Looks great!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants