Explain restart decision and display in alloc-status #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -76,6 +93,7 @@ func (r *RestartTracker) GetState() (string, time.Duration) { | |||
|
|
|||
| // Hot path if no attempts are expected | |||
| if r.policy.Attempts == 0 { | |||
| r.reason = ReasonNoRestartsAllowed | |||
There was a problem hiding this comment.
Don't you need to acquire a lock before setting the reason.
There was a problem hiding this comment.
It is locked at the top of GetState
dadgar
force-pushed
the
f-unrecoverable-error
branch
2 times, most recently
from
3ede6c9
to
2a4391d
Compare
dadgar
force-pushed
the
f-unrecoverable-error
branch
from
2a4391d
to
6e779b8
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an explanation to restart decisions and displays them in alloc-status