UI: Topology info panel incorrect accounting bugs #9886
Conversation
This would only ever realistically happen with fixture data, but still good to not have these warnings.
This fixes a couple bugs 1. Overreporting resources reserved due to counting terminal allocs 2. Overreporting unique client placements due to uniquing on object refs instead of on client ID.
Ember Asset Size actionAs of 73be2c3 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
backspace
force-pushed
the
b-ui/topo-viz-accounting
branch
from
e5af883
to
703b292
Compare
backspace
force-pushed
the
b-ui/topo-viz-accounting
branch
from
703b292
to
73be2c3
Compare
There was a problem hiding this comment.
👍
I noticed a “simple” merge conflict from ff252db that I first fixed in the web console and then had to do two subsequent force pushes to fully fix… including changing the tests. I probably should have just left it alone for you, sorry, as I know you tend to like to rebase! 😳
Ember Test Audit comparison
|
|
No worries! One less merge conflict I have to resolve, thanks! |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #9800
The cluster info panel was over-reporting reserved amounts due to counting the reserved capacity for terminal allocations. This fixes that bug.
Additionally, the topo viz node component did the same over-reporting by counting all allocs instead of only the pending and running ones.
This also adds acceptance tests to all the info panel states, and by writing those tests I discovered another bug: the unique allocation placements figure was always equal to the number of sibling allocations instead of the count of unique clients. I fixed that.