UI: Cross region server monitor #9913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember Asset Size actionAs of 2c13731 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
DingoEatingFuzz
force-pushed
the
b-ui/cross-region-server-monitor
branch
from
f7e979e
to
b2faf8a
Compare
Ember Test Audit comparison
|
backspace
suggested changes
Jan 29, 2021
| @@ -72,13 +72,15 @@ module('Integration | Component | agent-monitor', function(hooks) { | |||
| assert.ok(logRequest.url.startsWith('/v1/agent/monitor')); | |||
| assert.ok(logRequest.url.includes('client_id=client1')); | |||
| assert.ok(logRequest.url.includes('log_level=info')); | |||
| assert.ok(logRequest.url.includes('log_level=info')); | |||
There was a problem hiding this comment.
Is this meant to be a different assertion? Or accidental copypaste? 😯
There was a problem hiding this comment.
I think this was vim betraying me? Dunno, but I'll clean it up.
The region will naturally be appended to URLs via token.authorizedRequest but agent members includes all servers across all regions so relying on the application-level region isn't good enough.
DingoEatingFuzz
force-pushed
the
b-ui/cross-region-server-monitor
branch
from
b2faf8a
to
2c13731
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8885
This was just some oversight. Switching regions and monitoring a server worked, but since the serves page lists all servers across all regions, we need to special case this one.