Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node drain metadata #9928

Closed
nickethier opened this issue Jan 29, 2021 · 2 comments · Fixed by #10250
Closed

Node drain metadata #9928

nickethier opened this issue Jan 29, 2021 · 2 comments · Fixed by #10250
Assignees
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/drain type/enhancement
Milestone

Comments

@nickethier
Copy link
Member

When a node is drained in Nomad there is no way to tell who triggered the drain or why. This becomes more of a need as tools like the Nomad Autoscaler become more widely used.

One possible solution is to allow an option field or fields to be submitted with the node drain api call that are then shown in the node events.

@schmichael
Copy link
Member

While it's tempting to add a generic emit a node event hook, I think a purpose built field for this is ideal so the UX is familiar:

git commit -m "We all know how to write commit messages"

nomad node drain -self -m "So let's add them to drains"

Not saying -m is the right option name, but I think that UX might be useful especially as more drains are orchestrated by code instead of humans.

@tgross tgross added this to Needs Roadmapping in Nomad - Community Issues Triage Feb 12, 2021
@cgbaker cgbaker moved this from Needs Roadmapping to In Progress in Nomad - Community Issues Triage Feb 12, 2021
@tgross tgross moved this from In Progress to Needs Roadmapping in Nomad - Community Issues Triage Feb 12, 2021
@cgbaker cgbaker self-assigned this Feb 12, 2021
@cgbaker cgbaker moved this from Needs Roadmapping to In Progress in Nomad - Community Issues Triage Feb 12, 2021
@cgbaker cgbaker added the stage/accepted Confirmed, and intend to work on. No timeline committment though. label Feb 12, 2021
@cgbaker cgbaker added this to the 1.0.4 milestone Feb 12, 2021
@tgross tgross removed this from In Progress in Nomad - Community Issues Triage Feb 16, 2021
@tgross tgross removed this from the 1.0.4 milestone Feb 23, 2021
@cgbaker cgbaker added this to the 1.1.0 milestone Apr 5, 2021
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/drain type/enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants