add prefix-search and auto-completion for scaling policy info command
#9964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgbaker
commented
Feb 3, 2021
| @@ -115,7 +115,7 @@ func (c *AllocStatusCommand) Run(args []string) int { | |||
| } | |||
|
|
|||
| // If args not specified but output format is specified, format and output the allocations data list | |||
| if len(args) == 0 && json || len(tmpl) > 0 { | |||
| if len(args) == 0 && (json || len(tmpl) > 0) { | |||
There was a problem hiding this comment.
we only want to do this if there were no args... previous parsing would go into list mode with args if template was specified, which i think was not the intended behavior. same below for eval status and job inspect.
lgfa29
approved these changes
Feb 4, 2021
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also, i think there was some bad boolean logic in a few other info-like commands
resolves #9787