diff --git a/nomad/state/state_store.go b/nomad/state/state_store.go index 91785decf16e..91b4598447fa 100644 --- a/nomad/state/state_store.go +++ b/nomad/state/state_store.go @@ -2124,6 +2124,16 @@ func (s *StateStore) getJobStatus(txn *memdb.Txn, job *structs.Job, evalDelete b } } + // system jobs are running until explicitly stopped (which is handled elsewhere) + if job.Type == structs.JobTypeSystem { + if job.Stop { + return structs.JobStatusDead, nil + } + + // Pending until at least one eval has completed + return structs.JobStatusRunning, nil + } + // The job is dead if all the allocations and evals are terminal or if there // are no evals because of garbage collection. if evalDelete || hasEval || hasAlloc { diff --git a/nomad/state/state_store_test.go b/nomad/state/state_store_test.go index 2151a4a421c2..1783f1cdbfbd 100644 --- a/nomad/state/state_store_test.go +++ b/nomad/state/state_store_test.go @@ -1635,6 +1635,7 @@ func TestStateStore_JobsByScheduler(t *testing.T) { for i := 0; i < 10; i++ { job := mock.SystemJob() + job.Status = structs.JobStatusRunning sysJobs = append(sysJobs, job) err := state.UpsertJob(2000+uint64(i), job) @@ -4464,6 +4465,43 @@ func TestStateStore_SetJobStatus_PendingEval(t *testing.T) { } } +// TestStateStore_SetJobStatus_SystemJob asserts that system jobs are still +// considered running until explicitly stopped. +func TestStateStore_SetJobStatus_SystemJob(t *testing.T) { + state := testStateStore(t) + job := mock.SystemJob() + + // Create a mock eval that is pending. + eval := mock.Eval() + eval.JobID = job.ID + eval.Type = job.Type + eval.Status = structs.EvalStatusComplete + if err := state.UpsertEvals(1000, []*structs.Evaluation{eval}); err != nil { + t.Fatalf("err: %v", err) + } + + txn := state.db.Txn(false) + status, err := state.getJobStatus(txn, job, true) + if err != nil { + t.Fatalf("getJobStatus() failed: %v", err) + } + + if expected := structs.JobStatusRunning; status != expected { + t.Fatalf("getJobStatus() returned %v; expected %v", status, expected) + } + + // Stop the job + job.Stop = true + status, err = state.getJobStatus(txn, job, true) + if err != nil { + t.Fatalf("getJobStatus() failed: %v", err) + } + + if expected := structs.JobStatusDead; status != expected { + t.Fatalf("getJobStatus() returned %v; expected %v", status, expected) + } +} + func TestStateJobSummary_UpdateJobCount(t *testing.T) { state := testStateStore(t) alloc := mock.Alloc()