Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: amazon: Update aws-sdk-go to v1.15.54 #6849

Merged
merged 1 commit into from
Oct 15, 2018

Conversation

rickard-von-essen
Copy link
Collaborator

@rickard-von-essen rickard-von-essen commented Oct 15, 2018

This adds support for credential_source, see aws/aws-sdk-go#2201
Closes #6717

This adds support for credential_source, see aws/aws-sdk-go#2201
Closes hashicorp#6717
@rickard-von-essen rickard-von-essen requested a review from a team as a code owner October 15, 2018 09:49
@rickard-von-essen rickard-von-essen changed the title amazon: Update aws-sdk-go to v1.15.54 WIP: amazon: Update aws-sdk-go to v1.15.54 Oct 15, 2018
@rickard-von-essen
Copy link
Collaborator Author

This is currently unverified.

Copy link
Contributor

@azr azr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should be good to merge as aws/aws-sdk-go people validated it 🙂

@rickard-von-essen
Copy link
Collaborator Author

Yeah, it should just work.

@azr
Copy link
Contributor

azr commented Oct 15, 2018

Tested it on aws-ebs using different scenarios; it went fine

@SwampDragons SwampDragons merged commit 6a28da4 into hashicorp:master Oct 15, 2018
@SwampDragons SwampDragons added this to the v1.3.2 milestone Oct 18, 2018
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

amazon-ebs: Uses the wrong credentials when using credential_source
3 participants