Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider-generator): use lazy loading of generated provider namespaces #3012

Closed
wants to merge 1 commit into from

Conversation

DanielMSchmidt
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt commented Jul 17, 2023

Waiting on aws/jsii#4181 to be merged and released

TODO

  • We might not need a package.json to be emitted, but we need to change jsii-srcmak to add an exports map for "." in the package.json it creates
  • The lazy index require calls need to be made to ./dirName instead of dirName
  • test that we take the right dir name for providers with renames / dashes

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants