Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a new setting to toggle early validation #1336

Closed
dbanck opened this issue Jul 31, 2023 · 1 comment · Fixed by #1353
Closed

Introduce a new setting to toggle early validation #1336

dbanck opened this issue Jul 31, 2023 · 1 comment · Fixed by #1353
Assignees
Labels
enhancement New feature or request

Comments

@dbanck
Copy link
Member

dbanck commented Jul 31, 2023

Language Server Version

v0.31.1

Problem Statement

Counterpart to hashicorp/vscode-terraform#1549

The early validation work will introduce new features to validate a configuration file. We want to allow users to turn this feature off (or on).


Part of hashicorp/vscode-terraform#720

Proposal

  • Extend the server capabilities with a new entry that is enabled by default
  • Check the new capability before running early validation
    • Only append the early validation hook if it's enabled

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants