Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit OTEL instrumentation with focus on links #1340

Open
radeksimko opened this issue Jul 31, 2023 · 0 comments
Open

Revisit OTEL instrumentation with focus on links #1340

radeksimko opened this issue Jul 31, 2023 · 0 comments
Labels

Comments

@radeksimko
Copy link
Member

Context

As part of #1327 we have instrumented various parts of the codebase to collect traces.

There we instrumented each job as a nested span, rather than root. While this reflects the relationships relatively accurately and this is helpful in the waterfall view in other contexts, it is not helpful for identifying jobs which take the most time as filtering capabilities are generally limited for nested spans.

Also, tracking time spent in the queue doesn't seem to be helping in this context either, as it clutters the waterfall view.

Screenshot 2023-07-31 at 16 23 29

Proposal

  • Replace the current span hierarchy rpc:* -> walk-path -> job spans with root spans:
    • rpc:* remains as-is
    • walk-path span becomes root span, with link back to rpc:* span
    • job-eval:* span becomes root span, with link back to walk-path and rpc:*
  • Remove job and job-wait:* spans entirely

The assumption is that in any OTEL data visualising tool (such as Honeycomb), the root spans are queryable, unlike the nested ones, so we can more easily get a list of the slowest jobs and drill into those and still retain the context (what triggered these jobs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant