Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make root module list support workspace relative paths #235

Closed
paultyng opened this issue Jul 14, 2020 · 1 comment · Fixed by #246
Closed

Make root module list support workspace relative paths #235

paultyng opened this issue Jul 14, 2020 · 1 comment · Fixed by #246
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@paultyng
Copy link
Contributor

Current Version

0.5.1

Use-cases

In VS Code, when you specify your list of root modules and you save that with your workspace, you need it to be compatible with any machine that could possible work on the repo, so the paths need to be relative to the workspace itself.

Proposal

We should support Windows/Unix style slash relative paths, preferably without needing a dot prefix, ie:

  • examples/wlan/
  • examples\basic\

And with/without trailing slashes:

  • examples/wlan
  • examples\basic

Ideally we should also support globbing / patterns, I will open a separate issue for that (there may already be one, unsure).

Related LSP methods

References

@ghost
Copy link

ghost commented Aug 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Aug 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants