Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings: break down indexing options #1010

Merged
merged 1 commit into from
Jul 22, 2022
Merged

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Jul 22, 2022

As per our internal conversation yesterday, this allows us to get best of both worlds where VS Code can present nice settings UI and LS isn't limited to a flat structure.

I will raise a separate PR to update all three terraform* options to follow the same principles as documented and further align it with https://github.com/hashicorp/vscode-terraform/blob/main/docs/settings-migration.md , i.e.

instead of

{
  "terraformExecPath": "",
  "terraformExecTimeout": "",
  "terraformExecLogFilePath": ""
}

we will accept

{
  "terraform": {
    "path": ""
    "timeout": ""
    "logFilePath": ""
  }
}

and any future (stable, non-experimental) settings can follow these principles.

@radeksimko radeksimko added enhancement New feature or request technical-debt labels Jul 22, 2022
@radeksimko radeksimko self-assigned this Jul 22, 2022
@radeksimko radeksimko force-pushed the f-break-down-indexing-opts branch from d2ba93e to d7beb2d Compare July 22, 2022 10:26
@radeksimko radeksimko marked this pull request as ready for review July 22, 2022 10:29
@radeksimko radeksimko requested a review from a team as a code owner July 22, 2022 10:29
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I like the approach of handling settings this way

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request technical-debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants