Pick core schema only based on required_version constraint
#1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
f-core-schema-via-constraints
branch
3 times, most recently
from
f9ed19c to
5c1c18c
Compare
radeksimko
force-pushed
the
f-core-schema-via-constraints
branch
from
5c1c18c to
7024141
Compare
radeksimko
force-pushed
the
f-core-schema-via-constraints
branch
from
7024141 to
83c4b47
Compare
radeksimko
force-pushed
the
f-core-schema-via-constraints
branch
from
eb63c44 to
3a8f27a
Compare
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on hashicorp/terraform-schema#129
Closes #993
UX Impact
While the primary motivation behind the change was performance, it brings a minor UX impact.
IntelliSense with too old version (e.g. 0.10)
Before: No IntelliSense available, most schema-dependent jobs providing data for IntelliSense fail, as per errors in log.
After: 0.12-based IntelliSense provided, no errors in log.
The UX for too new version (e.g. 1.5.0) and for when the version is not known (yet) remains practically the same, it is just hopefully more obvious from the changed code combined with the upstream tfschema changes.