Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean/ci: avoid running tests via GoReleaser & remove GO111MODULE #1039

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Aug 12, 2022

This is to avoid some CPU/time waste on running tests twice on every PR/push, which we generally always do as per our current GHA workflow setup.

on:
pull_request:
branches:
- main
push:
branches:
- main

It does mean we'd no longer run tests as part of a release pipeline, but I'm not sure that was ever that much valuable anyway since we'd usually wait for the last main push CI workflow to turn green.

I'm also removing an old ENV variable GO111MODULE which is no longer relevant in the Go version we use.

@radeksimko radeksimko added the ci Continuous integration/delivery related label Aug 12, 2022
@radeksimko radeksimko self-assigned this Aug 12, 2022
@radeksimko radeksimko requested a review from a team as a code owner August 12, 2022 12:19
@radeksimko radeksimko merged commit f12ab09 into main Aug 12, 2022
@radeksimko radeksimko deleted the cleanup-goreleaser branch August 12, 2022 13:07
@dbanck dbanck added this to the v0.29.1 milestone Aug 24, 2022
@github-actions
Copy link

This functionality has been released in v0.29.1 of the language server.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci Continuous integration/delivery related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants