Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add copywrite config #1178

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Add copywrite config #1178

merged 2 commits into from
Feb 21, 2023

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Feb 14, 2023

No description provided.

@jpogran jpogran marked this pull request as ready for review February 14, 2023 18:26
@jpogran jpogran requested a review from a team as a code owner February 14, 2023 18:26
radeksimko
radeksimko suggested changes Feb 15, 2023
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the .github folder somehow appears to be ignored when header_ignore is not defined in the config, I'm getting the sense there's some inconsistency and possibly bug, which seems worth reporting and fixing first, before we merge this.

radeksimko
radeksimko approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just got confused about the output of copywrite, .github is not ignored unless explicitly listed under header_ignore.

:shipit:

.copywrite.hcl Outdated Show resolved Hide resolved
@jpogran @radeksimko
Update .copywrite.hcl
c78aa5a 
Co-authored-by: Radek Simko <radek.simko@gmail.com>
@jpogran jpogran merged commit b97114b into main Feb 21, 2023
@jpogran jpogran deleted the add-copywrite-config branch February 21, 2023 16:50
@radeksimko radeksimko mentioned this pull request Feb 21, 2023
Closed
3 tasks
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpogran @radeksimko