Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactoring(parser): Pass around tokens instead of blocks #125

Merged
merged 4 commits into from
May 29, 2020
Merged

refactoring(parser): Pass around tokens instead of blocks #125

merged 4 commits into from
May 29, 2020

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented May 28, 2020 •
edited
Loading

Previously we were passing around (either generic hcl or hclsyntax) blocks which don't carry sufficient details about the block when it comes to completion of incomplete configs, as described in #12 (comment)

This PR refactors the parsing logic to pass around hclsyntax.Tokens instead as that carries the right amount of details we need.

The PR should however be a no-op from user's perspective.

@radeksimko radeksimko mentioned this pull request May 28, 2020
Closed
@radeksimko radeksimko force-pushed the r-token-passing branch 2 times, most recently from 2c3dc07 to d424744 Compare May 28, 2020 17:47
@radeksimko radeksimko marked this pull request as ready for review May 28, 2020 19:29
@radeksimko radeksimko mentioned this pull request May 28, 2020
Merged
paultyng
paultyng approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@paultyng paultyng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would prefer comments be added when ignoring an error return explaining why.

@radeksimko radeksimko merged commit f7345a3 into master May 29, 2020
@radeksimko radeksimko deleted the r-token-passing branch May 29, 2020 08:03
@ghost
Copy link

ghost commented Jun 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Jun 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paultyng paultyng paultyng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @paultyng