Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Pull in gopls v0.10.0 tsprotocol.go #1256

Merged
merged 3 commits into from
Apr 25, 2023
Merged

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Apr 24, 2023

The main motivation here is to address a long-time bug which was originally "planted" in August 2021 as part of #608 and made visible via #1017 about 1 year later.

TL;DR older structs representing the LSP spec don't allow LabelDetails to be empty because the underlying type is a struct, rather than pointer which could be nil-ed and this codepath became active when we introduced completion resolution.

/**
* Additional details for the label
*
* @since 3.17.0 - proposed state
*/
LabelDetails CompletionItemLabelDetails `json:"labelDetails,omitempty"`

It also takes into account upstream changes made in golang/tools@b15dac2

UX Before

2023-04-24 13 47 20

UX After

2023-04-24 13 48 07

@radeksimko radeksimko added bug Something isn't working dependencies Auto-pinning labels Apr 24, 2023
@radeksimko radeksimko self-assigned this Apr 24, 2023
@radeksimko radeksimko force-pushed the deps-bump-lsp-protocol-file branch 11 times, most recently from a2210b4 to dfc328a Compare April 24, 2023 16:04
@radeksimko radeksimko force-pushed the deps-bump-lsp-protocol-file branch from dfc328a to f37dccb Compare April 24, 2023 16:08
@radeksimko radeksimko marked this pull request as ready for review April 24, 2023 17:35
@radeksimko radeksimko requested a review from a team as a code owner April 24, 2023 17:36
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great work

@radeksimko radeksimko merged commit 790339b into main Apr 25, 2023
@radeksimko radeksimko deleted the deps-bump-lsp-protocol-file branch April 25, 2023 10:29
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working dependencies Auto-pinning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants