deps: Pull in gopls v0.10.0 tsprotocol.go #1256
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation here is to address a long-time bug which was originally "planted" in August 2021 as part of #608 and made visible via #1017 about 1 year later.
TL;DR older structs representing the LSP spec don't allow
LabelDetails
to be empty because the underlying type is a struct, rather than pointer which could benil
-ed and this codepath became active when we introduced completion resolution.terraform-ls/internal/protocol/protocol.go
Lines 871 to 876 in 9e39956
It also takes into account upstream changes made in golang/tools@b15dac2
UX Before
UX After