textDocument/complete: Pass TextEdit instead of static text #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njuCZ
reviewed
Jun 3, 2020
paultyng
reviewed
Jun 3, 2020
paultyng
approved these changes
Jun 3, 2020
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #132
This seemingly small change has a positive effect on the UX while completing in the middle of an existing token, where clients can correctly highlight parts of completion candidates.
Before
After
As mentioned in the comment in code, this doesn't work (yet) for block types (e.g.
resource,data,provider). It probably should, but some refactoring is necessary to make that work and realistically changing of block type is far less likely to occur in real scenarios, so it's ok to take on that tech debt.