Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove third party GH action #213

Merged
merged 2 commits into from
Jul 8, 2020
Merged

Remove third party GH action #213

merged 2 commits into from
Jul 8, 2020

Conversation

paultyng
Copy link
Contributor

@paultyng paultyng commented Jul 8, 2020

Simplifies reading the file by just using a cat and the built-in functions for ::set-output: https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#using-workflow-commands-to-access-toolkit-functions

@radeksimko radeksimko force-pushed the paultyng-patch-1 branch 5 times, most recently from da27f3a to f992bef Compare July 8, 2020 07:25
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good idea. It took me a few tries to make it work for Windows, but I also reflected this in the CI workflow.

Overall though I really hope actions/setup-go#62 is merged and we can simplify this.

@radeksimko radeksimko merged commit e8411e8 into master Jul 8, 2020
@radeksimko radeksimko deleted the paultyng-patch-1 branch July 8, 2020 07:33
@ghost
Copy link

ghost commented Aug 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Aug 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants