terraform/schema: Make schema storage version-aware #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
b-version-aware-schema-storage
branch
4 times, most recently
from
f683a6b to
368c43d
Compare
radeksimko
force-pushed
the
b-version-aware-schema-storage
branch
from
368c43d to
bf0541a
Compare
appilon
approved these changes
Jul 22, 2020
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User impact
This doesn't yet fully implement 0.13 support nor does it deal with provider aliasing, but at least provides backward-compatible functionality for 0.12-style configs in 0.13 where provider sources aren't declared explicitly.
Before
After
Implementation details
The new
internal/terraform/addrspackage is mostly just a copy of these two files:https://github.com/hashicorp/terraform/blob/master/addrs/provider.go
https://github.com/hashicorp/terraform/blob/master/addrs/provider_test.go
I just omitted functions which LS doesn't need (yet) and changed error handling from
tfdiagsto simpler multierror.I intentionally didn't copy the whole package yet, but it may come down it as it's likely one of the ways of resolving #36 reliably.