internal/filesystem: Integrate spf13/afero #249
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (slightly bigger) PR has a few motivating factors:
*.tf
files in a directory and we can't expect that all relevant files in the directory are opened by the client.This complexity deserves a clearer separation between raw filesystem API and the "document API" (per LSP's naming convention) where document is a file which holds some additional metadata the language server needs to access to comply with the protocol.
afero.Fs
, which makes it a natural choice for the language server as well.Relevant WIP is in b46ec44 and https://github.com/hashicorp/terraform-config-inspect/pull/49/files
This is just an initial refactoring PR which integrates with afero's in-memory filesystem and should have no effect on the end-user.
Related: