Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ilsp: Fix miscalculated semantic tokens #390

Merged
merged 1 commit into from
Feb 3, 2021
Merged

ilsp: Fix miscalculated semantic tokens #390

merged 1 commit into from
Feb 3, 2021

Conversation

radeksimko
Copy link
Member

Fixes #387

This affects most cases where there is more than 2 tokens on the same line (typically blocks with 2 labels, like resources and data sources), in which case the deltaStartChar was being miscalculated.

Before

Screenshot 2021-02-03 at 11 49 33

After

Screenshot 2021-02-03 at 11 48 56

@radeksimko radeksimko added bug Something isn't working textDocument/semanticTokens Semantic syntax highlighting labels Feb 3, 2021
@radeksimko radeksimko requested a review from a team February 3, 2021 11:52
@radeksimko radeksimko mentioned this pull request Feb 3, 2021
Closed
aeschright
aeschright approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@aeschright aeschright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@radeksimko radeksimko merged commit 6ee0dd0 into main Feb 3, 2021
@radeksimko radeksimko deleted the b-fix-sem-token-encoder branch February 3, 2021 21:51
@ghost
Copy link

ghost commented Mar 5, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aeschright aeschright aeschright approved these changes

Assignees
No one assigned
Labels
bug Something isn't working textDocument/semanticTokens Semantic syntax highlighting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect semantic highlighting for block braces
2 participants
@radeksimko @aeschright