Reduce CPU usage via custom Copy methods instead reflection #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
f-copy-funcs
branch
2 times, most recently
from
d74a943 to
7ee84bb
Compare
radeksimko
changed the title
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on hashicorp/hcl-lang#40
Depends on hashicorp/terraform-schema#44
Closes #509
The rationale and more context is described in #509 - I can estimate that this will reduce the CPU usage in the hot path (state manipulation) by ~66% (from ~3sec to ~1sec in my configuration) based on this snapshot of a CPU profile collected from a build based on this PR:
The "new" bottleneck is JSON decoding, which is something we could address via #506