Provide (less verbose) step-based completion #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
f-step-based-completion
branch
from
45a3604 to
87505c6
Compare
radeksimko
force-pushed
the
f-step-based-completion
branch
2 times, most recently
from
bef6163 to
52c9062
Compare
radeksimko
force-pushed
the
f-step-based-completion
branch
from
52c9062 to
09d38f9
Compare
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #492
Step-based completion basically offers only the top-most reference (from hierarchy perspective) that matches what is already written (any characters after
=). In other words completion for empty expression such asattribute = # HEREwould bring up only top-level references.Additionally this patch also provides decoding for references to addressable elements within some non-primitive types - namely attributes within object expressions, map entries, and list entries.
Depends on hashicorp/hcl-lang#56
Before
After