Make references scope & type aware #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
added
enhancement
radeksimko
force-pushed
the
f-type-aware-refs
branch
from
416cf4c to
5f5adce
Compare
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously reference origins/addresses (such as
var.foo) would be matched against addressable targets (attributes or blocks) in a strict fashion where addresses have to match exactly.This patch makes origins scope & type aware as per hashicorp/hcl-lang#68 which in turn helps us "optimistically" recognize references to targets of unknown type.
Before
References to
var.testare not recognized (no data provided on hover, reference not semantically highlighted, no go-to-definition etc.) due to the variable not having explicit type.After
On hover we display the closest known target (for clarity).