-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal: expose pending tf related options via init opts #619
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this 2nd PR as well.
Aside from my two inline comments it looks good.
We'll also need to document these new options in https://github.com/hashicorp/terraform-ls/blob/main/docs/SETTINGS.md but I'm happy to do that prior to merging.
Actually one more thing: terraform-ls/internal/cmd/serve_command.go Lines 46 to 49 in 0059475
Thanks. |
3c901dd
to
a0b5398
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I just made some minor changes to the docs and log message.
Thanks for the PR.
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Closes #240