Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: expose pending tf related options via init opts #619

Merged
merged 3 commits into from
Aug 23, 2021

Conversation

danishprakash
Copy link
Contributor

Closes #240

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this 2nd PR as well.

Aside from my two inline comments it looks good.

We'll also need to document these new options in https://github.com/hashicorp/terraform-ls/blob/main/docs/SETTINGS.md but I'm happy to do that prior to merging.

internal/settings/settings.go Outdated Show resolved Hide resolved
internal/langserver/handlers/service.go Show resolved Hide resolved
internal/langserver/handlers/service.go Outdated Show resolved Hide resolved
@radeksimko
Copy link
Member

Actually one more thing:
Can you also prepend the relevant two CLI flags with (DEPRECATED)?

fs.StringVar(&c.tfExecTimeout, "tf-exec-timeout", "", "Overrides Terraform execution timeout (e.g. 30s)")
fs.StringVar(&c.tfExecLogPath, "tf-log-file", "", "path to a file for Terraform executions"+
" to be logged into with support for variables (e.g. Timestamp, Pid, Ppid) via Go template"+
" syntax {{.VarName}}")

Thanks.

docs/SETTINGS.md Outdated Show resolved Hide resolved
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just made some minor changes to the docs and log message.

Thanks for the PR.

@radeksimko radeksimko merged commit d9ad7f8 into hashicorp:main Aug 23, 2021
@radeksimko radeksimko added the enhancement New feature or request label Aug 23, 2021
@radeksimko radeksimko added this to the v0.21.0 milestone Aug 23, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose Terraform-related options via native LSP "InitializationOptions"
2 participants