Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemas: exclude ciphertrust #692

Merged
merged 1 commit into from
Nov 3, 2021
Merged

schemas: exclude ciphertrust #692

merged 1 commit into from
Nov 3, 2021

Conversation

radeksimko
Copy link
Member

This is to address the failing CI build which is caused by the fact that the provider only has a single release, which is a pre-release (beta1) and since we don't provide any version constraints in our generated configs it implicitly excludes prereleases.

https://github.com/hashicorp/terraform-ls/runs/4065743149?check_suite_focus=true#step:6:65

@radeksimko radeksimko requested a review from a team November 1, 2021 13:41
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we somehow track changes on this provider to get notified when a non-beta version is released so that we can remove this from the ignore list?

@radeksimko
Copy link
Member Author

That is a good question, I guess the best way would be one/any of us watching the repo for releases.

However I always considered pre-building the schemas an imperfect solution and so I think that a few missing providers is not going to make a huge difference in grand scheme of things.

I guess some of the providers on the current ignore list could be removed now too. We just haven't invested the time into investigating whether they download correctly now.

@radeksimko radeksimko merged commit b3a6a09 into main Nov 3, 2021
@radeksimko radeksimko deleted the exclude-ciphertrust branch November 3, 2021 10:20
@github-actions
Copy link

github-actions bot commented Dec 4, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants