Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce go-to-variable from module input name #700

Merged
merged 12 commits into from
Nov 23, 2021
Merged

Introduce go-to-variable from module input name #700

merged 12 commits into from
Nov 23, 2021

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Nov 8, 2021 •
edited
Loading

@radeksimko radeksimko added the enhancement New feature or request label Nov 8, 2021
This was referenced Nov 8, 2021
Merged
Merged
@radeksimko radeksimko mentioned this pull request Nov 9, 2021
Merged
@radeksimko radeksimko force-pushed the f-path-target branch 24 times, most recently from 34290a5 to be0d532 Compare November 16, 2021 21:27
@radeksimko radeksimko force-pushed the f-path-target branch 4 times, most recently from 8431c2d to f3392f2 Compare November 18, 2021 12:30
@radeksimko radeksimko marked this pull request as ready for review November 18, 2021 12:47
@radeksimko
deps: bump hcl-lang & terraform-schema
6917367
@radeksimko
Introduce go-to-variable from module input name
548a119 
Basically just reflecting all breaking changes upstream
in hcl-lang and terraform-schema.
@radeksimko
walker: Ensure references are collected & variables parsed
ca10955
@radeksimko
handlers/hooks: Enable code lens refresh
5cb7717
@radeksimko
handlers: add tests for definition + references
f6b6033
@radeksimko
fix: Ensure only relevant origins/targets are in PathContext
03893f3 
This prevents over-estimation of references in code lens
as a result of mistakenly reusing module references in variable files.
@radeksimko
fix: mark duplicate module operation as done
d69e70d 
This is to prevent deadlock in tests, which may still occasionally
end up in a situation where two or more of the same operations
are scheduled at a time.
@radeksimko
reduce go test timeout
d15985e
@radeksimko
add time.Sleep to cross-module tests
5e6f1c7
@radeksimko radeksimko requested a review from a team November 18, 2021 13:08
radeksimko and others added 2 commits November 18, 2021 15:36
@radeksimko @dbanck
Update internal/langserver/handlers/hooks_module.go
4cea392 
Co-authored-by: Daniel Banck <dbanck@users.noreply.github.com>
@radeksimko @dbanck
Update internal/langserver/handlers/hooks_module.go
5fc0fc2 
Co-authored-by: Daniel Banck <dbanck@users.noreply.github.com>
@radeksimko radeksimko mentioned this pull request Nov 22, 2021
Closed
7 tasks
dbanck
dbanck approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Awesome work!

@radeksimko radeksimko merged commit 5740123 into main Nov 23, 2021
@radeksimko radeksimko deleted the f-path-target branch November 23, 2021 15:18
@jamiet-msm
Copy link

NICE!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbanck dbanck dbanck approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Go to variable definition (from local module arg)
3 participants
@radeksimko @jamiet-msm @dbanck