Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform/exec: Treat TempDir related vars as safe to pass through #78

Merged
merged 2 commits into from
Apr 30, 2020

Conversation

radeksimko
Copy link
Member

Closes #77

@radeksimko radeksimko added the bug Something isn't working label Apr 30, 2020
Copy link
Contributor

@paultyng paultyng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, are there others you should pass through, ie TF_VAR_* or something?

@radeksimko
Copy link
Member Author

radeksimko commented Apr 30, 2020

re TF_VAR_* - We can't really do anything useful with these variables yet (it's not relevant for version or providers schema).

More importantly though it is questionable whether the user can ensure that these ENV vars actually get propagated to the IDE in the first place and whether the IDE would pass them down to the server.

And even if they did, I have some doubts we'd interpret them the way user expects them to be interpreted - specifically because single IDE instance can serve many directories, each requiring different variables/context. So unless all of your variables apply to all projects you're working on, it would cause more confusion, because these variables will share the lifecycle of the IDE.

Terraform should however automatically load terraform.tfvars and we could also introduce a config option load_tfvars which would additionally attempt to load tfvars file of a given name in any directory or something like that.

@radeksimko radeksimko merged commit c29fd7a into master Apr 30, 2020
@radeksimko radeksimko deleted the b-pass-tmp-vars branch April 30, 2020 10:41
@ghost
Copy link

ghost commented Jun 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Jun 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make server work under non-admin user on Windows
2 participants