Update semantic token block label type #802
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the type for block labels from string to enum member.
It's the first step in providing more contextual information on block labels. With a schema update, it will be possible to differentiate between multiple block labels. This will allow us to report two different tokens for block labels where the first one stays enum member and the second one becomes a string.
We've tried different token types, like
class
,macro
,method
, andenumMember
and settled on the latter.enumMember
makes the most sense from a semantic perspective and has good highlighting in the default themes.Having semantic tokens for block labels enables better highlighting for nested blocks.
Before (no LS)
After (with LS)
For a smoother user experience, we propose to update the static grammar for block labels from
entity.name.tag.terraform
tovariable.other.enummember
. This change would update the raw grammar version (no LS) to this:Closes #777